Speed up test_car_interfaces.py #34339
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
|
For those types of speedup issues, please post a clear before and after benchmark of the required metrics (in this case we need the average duration + maximum duration on a Github runner, not on your local machine). |
| ALL_ECUS = {ecu for ecus in FW_VERSIONS.values() for ecu in ecus.keys()} | ||
| ALL_ECUS |= {ecu for config in FW_QUERY_CONFIGS.values() for ecu in config.extra_ecus} | ||
|
|
||
| ALL_REQUESTS = {tuple(r.request) for config in FW_QUERY_CONFIGS.values() for r in config.requests} | ||
|
|
||
| MAX_EXAMPLES = int(os.environ.get('MAX_EXAMPLES', '60')) | ||
| MAX_EXAMPLES = int(os.environ.get('MAX_EXAMPLES', '20')) |
There was a problem hiding this comment.
This won't affect the test coverage in CI (or the speed of the tests) since we already specify the MAX_EXAMPLES in our yaml, but it will if you run this test outside of CI.
Even though it won't technically reduce coverage, this change kind of goes against the requirements of the issue, since we explicitly specify "with the same test coverage".
This PR pertains to this bounty: #32536
Description
Decreases the time taken for testing
test_car_interfaces.pyfrom ~3s max initially, 1.5-2s for the longest tests, to 1s max and 0.3s for the longest tests.List of changes:
Verification
On my machine these fixes bring it within the max tolerance for time specified in the original issue: