Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op.sh start stop restart #34404

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Jan 17, 2025

This PR introduces three new commands to op.sh for managing the comma service:

op start: Starts the comma service.
op stop: Stops the comma service.
op restart: Restarts the comma service.

@github-actions github-actions bot added the tools label Jan 17, 2025
@royjr royjr marked this pull request as ready for review January 17, 2025 05:09
tools/op.sh Outdated Show resolved Hide resolved
@royjr
Copy link
Contributor Author

royjr commented Jan 17, 2025

worked yesterday but now the start and restart commands keep triggering the reset screen becuase of taps

waiting for weston
weston ready after 0s
launching system reset, got taps
Using Wayland-EGL
MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
libEGL warning: egl: failed to create dri2 screen
qt.qpa.wayland: "wl-shell" is a deprecated shell extension, prefer using "xdg-shell-v6" or "xdg-shell" if supported by the compositor by setting the environment variable QT_WAYLAND_SHELL_INTEGRATION
Using the 'wl-shell' shell integration
qt.qpa.wayland: Wayland does not support QWindow::requestActivate()
cat /sys/devices/platform/soc/894000.i2c/i2c-2/2-0017/touch_count
16

@adeebshihadeh
Copy link
Contributor

If you make a PR to fix that soon, I can get it into AGNOS 11.5. #34413

@adeebshihadeh adeebshihadeh marked this pull request as draft January 18, 2025 18:59
@royjr
Copy link
Contributor Author

royjr commented Jan 19, 2025

Actually restarts now without getting stuck on reset screen, but seems to lock and crash ui (black screen) within a minute until full power cycle, need to investigate further. Only other user who resported got taps issue a year ago doesn't seem to have the issue anymore who still uses the systemctl commands.

@adeebshihadeh adeebshihadeh mentioned this pull request Jan 19, 2025
29 tasks
@adeebshihadeh
Copy link
Contributor

commaai/agnos-builder@d39db39

@adeebshihadeh adeebshihadeh marked this pull request as ready for review January 23, 2025 00:59
@adeebshihadeh adeebshihadeh merged commit feb9b1c into commaai:master Jan 23, 2025
15 checks passed
@royjr royjr deleted the op-start-stop-restart branch January 23, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants