ui: preview driver monitor crashes UI on exit

[sunnyhaibin]

Describe the bug

• Possibly introduced in ui: refactor driver monitor updating and rendering into DriverMonitorRenderer class #33375, UI crashes on exit of DriverViewDialog.
• Confirmed that 0.9.7 release did not have this behavior - it resets back to offroad home screen on exit of DriverViewDialog.

IMG_4909.mov

Provide a route where the issue occurs

69cd3a350561a4d8

openpilot version

c515021

Additional info

No response

[deanlee]

I believe this issue is not related to the UI itself. The UI is being terminated by the watchdog due to a VIPC issue, which may occur after repeated connect/disconnect with the VIPC server (after camerad restarted). commaai/msgq#624

#29769 refactors DriverView to disconnect from the VIPC server after the preview, which makes this VIPC bug easier to trigger. Previously, the VIPC connection stayed active with camerad even after the preview.

Has this already been resolved with commaai/msgq#638 ?

[deanlee]

There are actually several different issues causing the UI to crash and trigger a restart:

1. ui: SIGABRT crash in Wayland client after CameraView destructor #34411
2. vipc issues: Properly checking the return value of ipc_sendrecv_with_fds msgq#624. which causes an assertion failure on repeated connect/disconnect:
   ui: msgq_repo/msgq/visionipc/visionipc_client.cc:128: static std::set<VisionStreamType> VisionIpcClient::getAvailableStreams(const std::string &, bool): Assertionr == sizeof(request)' failed.`