Sd 607 provide the compelete name of target cluster in promotion prs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stealing traffic means the Telefonistka instance running in the cluster will not receive the webhook, only the local instance will. This is so that we only see results from our local instance.
The promotion path used to look like 'source/'->['path1/','path2/']. This PR changes it to look like: 'source/'-> 'path1/' 'path2/'
ashvarts
requested review from
a team,
hnnsgstfssn,
Freyert,
Oded-B,
yzdann,
sunchill06 and
jared-logan-patrick-ct
|
Love the test! I think if the file ending for the golden path were |
ashvarts
force-pushed
the
sd-607-provide-the-compelete-name-of-target-cluster-in-promotion-prs
branch
from
07285c6
to
bb8e932
Compare
Freyert
previously approved these changes
Aug 30, 2024
Oded-B
previously approved these changes
Aug 30, 2024
yzdann
previously approved these changes
Sep 2, 2024
Comment on lines
189
to
191
| // if newPrBody != expectedPrBody { | ||
| // t.Errorf("Expected prBody to be %s, got %s", expectedPrBody, newPrBody) | ||
| // } |
just for my knowledge ... in what sense this will improve the network configuration? |
|
@yzdann that's referring to mirrord. I'll confess that it's how CoPilot worded it. But the enhancement is that the traffic will be redirected to the local binary only, so during development only the local telefonistka will get webhooks, not the one running in the cluster, this should make it easier to test things. |
yzdann
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
internal/pkg/githubapi/github.goandmirrord.jsonfiles to improve the formatting of promotion PR bodies and update network configuration settings respectively.Improvements to PR Body Formatting:
internal/pkg/githubapi/github.go: Updated thegeneratePromotionPrBodyfunction to improve the formatting of target paths in the promotion PR body. The target paths are now joined with a newline and indentation for better readability.Before:
After:
jira: SD-607: Telefonistka doesn't provide the complete name of target cluster in promotion PRs
Network Configuration Updates:
mirrord.json: Added a newnetworksection withincomingset to "steal" andoutgoingset to true, enhancing the network configuration settings.These changes aim to enhance the usability, maintainability, and functionality of the Telefonistka project.
Type of Change
Checklist