Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ekg-json, ekg-statsd, ekg #7497

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add ekg-json, ekg-statsd, ekg #7497

merged 3 commits into from
Aug 5, 2024

Conversation

L0neGamer
Copy link
Contributor

@L0neGamer L0neGamer commented Jul 31, 2024 •
edited
Loading

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • [ ] If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@L0neGamer
Copy link
Contributor Author

Hi, ekg-json has been updated to work with stackage.
Recently, I gained ownership over the ekg packages, and will work on getting them up to date soon, hence adding them under my maintainership but not removing the sub-zero deps.

@L0neGamer L0neGamer changed the title add-ekg-json Add ekg-json Jul 31, 2024
@L0neGamer
Copy link
Contributor Author

please wait on this; I'm planning on adding ekg-statsd as well, and potentially looking into ekg itself

@L0neGamer L0neGamer changed the title Add ekg-json Add ekg-json, ekg-statsd Jul 31, 2024
@L0neGamer L0neGamer changed the title Add ekg-json, ekg-statsd Draft: Add ekg-json, ekg-statsd Jul 31, 2024
@L0neGamer L0neGamer changed the title Draft: Add ekg-json, ekg-statsd Add ekg-json, ekg-statsd, ekg Jul 31, 2024
@L0neGamer
Copy link
Contributor Author

Hackage uploads will be 30 minutes old in <30mins.

ekg doesn't work with verify-package script because ekg-json is not on stackage.

bergmark
bergmark approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@bergmark bergmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bergmark bergmark merged commit f53b895 into commercialhaskell:master Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmark bergmark bergmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L0neGamer @bergmark