Enhancement: Enable Jetpack Compose

[AbdhilahiRWabwire]

Jetpack Compose

This pull request audits the Gradle Build, Updates Dependencies, Migrates from KAPT to KSP, Enables Jetpack Compose and Enables Dependabot

• dependabot.yml - Automated dependency updates built into GitHub

• https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

• https://github.com/dependabot

[nicolas-raoul]

Is this about an existing bug or enhacement request? If yes would you mind providing the URL? Thanks!

[AbdhilahiRWabwire]

This is GitHub Dependabot. Dependabot automatically updates dependencies in GitHub Projects. Dependabot is built into GitHub.

[nicolas-raoul]

Do we really need this? Do we use Maven dependencies?

[AbdhilahiRWabwire]

Dependabot updates Gradle dependencies and Maven packages in unison. For this to work, both must be declared. In fact, Gradle projects benefit the most from Dependabot. Everyone loves Dependabot.

[nicolas-raoul]

I think it would be great to have it indeed.
Would you mind trying that bot on your fork, so that we can see whether unit tests still pass after the bot has updated dependencies? There will probably be a lot of updates the first time, so better have the fixes ready. Thanks! :-)

[AbdhilahiRWabwire]

Understood

[AbdhilahiRWabwire]

@nicolas-raoul Task Complete: com.jackwharton.rxbinding could not be updated because of conflicts with io.reactivex.rxjava

[AbdhilahiRWabwire]

@nicolas-raoul AVD fails if JDK is updated but the current version of Android Studio uses JDK 17 and JBR 17

[nicolas-raoul]

Nice, that's very promising! :-)

Somehow the build fails with this error, any idea why?
app/src/main/java/fr/free/nrw/commons/customselector/helper/OnSwipeTouchListener.kt: (42, 9): 'onFling' overrides nothing

I am looking forward to testing the app with all of these updates. :-)

[AbdhilahiRWabwire]

@nicolas-raoul Thank you sir. I am fixing that error now. It is com.android.tools.build. I believe it is a build error in general and not the class itself.

[AbdhilahiRWabwire]

@nicolas-raoul

app/src/main/java/fr/free/nrw/commons/customselector/helper/OnSwipeTouchListener.kt: (42, 9): 'onFling' overrides nothing

This line of code requires a manual fix. I will have to go through the code base and fix it.

[nicolas-raoul]

Wow, thanks a lot! :-)
I believe that flings are only used in that activity.

[AbdhilahiRWabwire]

@nicolas-raoul

• Fixing:

Accidental override: The following declarations have the same JVM signature (onFling(Landroid/view/MotionEvent;Landroid/view/MotionEvent;FF)Z):

• Also:

'getMetrics(DisplayMetrics!): Unit' is deprecated. Deprecated in Java

'getter for defaultDisplay: Display!' is deprecated. Deprecated in Java

[AbdhilahiRWabwire]

@nicolas-raoul Fixed Accidental override: The following declarations have the same JVM signature (onFling(Landroid/view/MotionEvent;Landroid/view/MotionEvent;FF)Z):

[AbdhilahiRWabwire]

@nicolas-raoul Execution failed for task ':app:connectedBetaDebugAndroidTest'.

[nicolas-raoul]

@AbdhilahiRWabwire I believe this pull request would be a wonderful addition to the app. If some updates are creating issues, how about using ignore to leave these ones untouched for now? :-)

[AbdhilahiRWabwire]

@nicolas-raoul Running Dependency Audit

[AbdhilahiRWabwire]

Refactoring broken Kotlin files that use KAPT

[nicolas-raoul]

Thanks for all of the work!

You can mark your pull request as "draft" until it is ready to review. :-)

[AbdhilahiRWabwire]

GitHub is not granting me permission to convert this Pull Request into a Draft.

[AbdhilahiRWabwire]

Some Views require Android API 33 to function but I have upgraded to Android API 34. I can fix the compatibility issue in the Views by refactoring.

[AbdhilahiRWabwire]

I see the Jetpack Compose Migration has begun.