Added date and time to Feedback #5797
Conversation
app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java
Outdated
Show resolved
Hide resolved
ujjwal2900
force-pushed
the
fix/5564_Feedback_should_contain_date_and_time
branch
from
2db3ee4
to
d9b8dee
Compare
| //Add the UTC Date and Time to Feedback | ||
| sectionTextBuilder.append("Generated on: "); | ||
| sectionTextBuilder.append(UTC_FormattedDateTime); | ||
| sectionTextBuilder.append("\n"); |
There was a problem hiding this comment.
This should be added to the title, rather than to the body section. So I suggest moving this to around line 49.
Also, to keep it concise, I suggest something shorter like just "on " + the date.
In the end, the title would look like this: Feedback from Nicolas for version 1.2.3 on 2023/12/31
|
Hi @nicolas-raoul , I have added just the date to the subject just to keep it short instead of adding the full date and time. |
| @@ -32,11 +35,19 @@ public void init() { | |||
| /* | |||
| * Construct the feedback section title | |||
| */ | |||
|
|
|||
| //Get the UTC Date and Time and add it to the Title | |||
| final SimpleDateFormat dateFormat = new SimpleDateFormat("dd/MM/yyyy", Locale.ENGLISH); | |||
There was a problem hiding this comment.
-
Would you mind making it
yyyy/MM/ddas it is a less ambiguous format? -
Please append
HH:mm:ssas users often report several things on the same day, and having the same title breaks the wikilinks.
So to summarize I think yyyy/MM/dd HH:mm:ss would be the best.
|
HI @nicolas-raoul , Pls review the last commit. I have changes the format as requested. |
* Add Date and Time in UTC format to Feedback * Add UTC date to the Subject instead of adding it to the body * Change the UTC Date format to yyyy/MM/dd HH:mm:ss * Minor changes --------- Co-authored-by: Nicolas Raoul <[email protected]>
Description (required)
Fixes #5564
What changes did you make and why?
Appended the current date and time to feedback which will help in understanding when was the feedback given and if the problem still exists.
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {Pixel Fold API 35} with API level {35}.