Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added date and time to Feedback #5797

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Added date and time to Feedback #5797

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9b8dee
Add Date and Time in UTC format to Feedback
ujjwal2900 Sep 1, 2024
e2cb091
Add UTC date to the Subject instead of adding it to the body
ujjwal2900 Sep 8, 2024
f37e241
Merge branch 'main' into fix/5564_Feedback_should_contain_date_and_time
nicolas-raoul Sep 9, 2024
dac6474
Change the UTC Date format to yyyy/MM/dd HH:mm:ss
ujjwal2900 Sep 12, 2024
9e13531
Change the UTC Date format to yyyy/MM/dd HH:mm:ss
ujjwal2900 Sep 12, 2024
3923d4f
Minor changes
ujjwal2900 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
import fr.free.nrw.commons.feedback.model.Feedback;
import fr.free.nrw.commons.utils.LangCodeUtils;
import java.util.Locale;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.TimeZone;

/**
* Creates a wikimedia recognizable format
Expand All @@ -32,6 +35,12 @@ public void init() {
/*
* Construct the feedback section title
*/

//Get the UTC Date and Time
final SimpleDateFormat dateFormat = new SimpleDateFormat("dd/MM/yyyy HH:mm:ss", Locale.ENGLISH);
dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
final String UTC_FormattedDateTime = dateFormat.format(new Date());

sectionTitleBuilder = new StringBuilder();
sectionTitleBuilder.append("Feedback from ");
sectionTitleBuilder.append(AccountUtil.getUserName(context));
Expand Down Expand Up @@ -96,6 +105,11 @@ public void init() {
}
sectionTextBuilder.append("~~~~");
sectionTextBuilder.append("\n");

//Add the UTC Date and Time to Feedback
sectionTextBuilder.append("Generated on: ");
sectionTextBuilder.append(UTC_FormattedDateTime);
sectionTextBuilder.append("\n");
Copy link
Member

@nicolas-raoul nicolas-raoul Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to the title, rather than to the body section. So I suggest moving this to around line 49.
Also, to keep it concise, I suggest something shorter like just "on " + the date.

In the end, the title would look like this: Feedback from Nicolas for version 1.2.3 on 2023/12/31

Screenshot 2024-09-02 at 13 47 07

}

public String getSectionText() {
Expand Down
Loading