Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization: fix incorrect Unicode for space after bullet points in French language #5824

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Localization: fix incorrect Unicode for space after bullet points in French language #5824

merged 3 commits into from
Sep 10, 2024

Conversation

rohit9625
Copy link
Contributor

@rohit9625 rohit9625 commented Sep 9, 2024 •
edited
Loading

Description (required)

Fixes #5821

What changes did you make and why?
Just a small fix for Unicode of space character

Tests performed (required)

Tested prodDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only)
None

@rohit9625 rohit9625 changed the title localization: fix incorrect unicode for space Localization: fix incorrect Unicode for space after bullet points in French language Sep 9, 2024
@nicolas-raoul
Copy link
Member

Just a small piece of advice: I would recommend creating branches on your local repository, such as issue5821_bullets, that would allow you to work on several tasks in parallel, as well as prevent possible confusion (for instance I already have a rohit9625-main branch on my local repository but it contains a different fix). Thanks a lot! 😃

@nicolas-raoul
Copy link
Member

This pull request solves the issue:
Screenshot_20240909-165822_Commons

However, this file will get overwritten the next time translations are pulled from TranslateWiki.

@rohit9625
Copy link
Contributor Author

Just a small piece of advice: I would recommend creating branches on your local repository, such as issue5821_bullets, that would allow you to work on several tasks in parallel, as well as prevent possible confusion (for instance I already have a rohit9625-main branch on my local repository but it contains a different fix). Thanks a lot! 😃

I will keep that in my mind next time. Because this was a small fix, so I just add push it to main directly.

@rohit9625
Copy link
Contributor Author

However, this file will get overwritten the next time translations are pulled from TranslateWiki.

So, I need to make a change on Gerrit also. Right?

nicolas-raoul
nicolas-raoul approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both French and English, works great.
Thanks a lot!

@nicolas-raoul nicolas-raoul merged commit 9edde23 into commons-app:main Sep 10, 2024
1 check passed
rohit9625 added a commit to rohit9625/apps-android-commons that referenced this pull request Sep 13, 2024
@rohit9625
Localization: fix incorrect Unicode for space after bullet points in …
6895b07 
…French language (commons-app#5824)

* localization: fix incorrect unicode for space

* Remove bullet string resource as it doesn't need translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial display unicode error in french
2 participants
@rohit9625 @nicolas-raoul