Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Fixed #5758: Category related functionality such as explore search, viewing parent and sub categories of a category don't work #5830

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

thesarangal
Copy link
Contributor

Description (required)

Fixes #5758

What changes did you make and why?
Changes were made to fix the UI Issue as described in #5758. When user navigate from Home Screen > Explore > Featured > Choose Any Media Post > Scroll to 'Categories' Section and Choose Any Category > Category Details Screen: On this screen when user navigate to 'SUBCATEGORIES' or 'PARENT CATEGORIES' tab, both screens show blank. It was due to optimisation was request for viewbinding handling in their parent fragments to fix this problem.

Tests performed (required)
Tested betaDebug on Android Studio Emulator with API level 34.

Screenshots (for UI changes only)
Due to the issue, the screens were showing as totally blank:

Screenshot_20240917_012612
Screenshot_20240917_012619

After ViewBinding Optimisation:
Screenshot_20240917_012941
Screenshot_20240917_012947

@thesarangal thesarangal changed the title Optimize the Layout ViewBinding Issue Fixed #5758: Category related functionality such as explore search, viewing parent and sub categories of a category don't work Sep 16, 2024
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Parent and child tabs are now working great, for both categories and depictions. Thanks a lot Rajat!

@nicolas-raoul nicolas-raoul merged commit f751ab4 into commons-app:main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants