Issue-5662-kotlinstyle

[tristan81]

Fixes #5662

• Bulk automated formatting updates on the code base using ktLint --format
• Multiple manual changes to meet ktLint standard rules including:
• removal of wildcard imports (standard:no-wildcard-imports)
• successive KDOC comments (standard:no-consecutive-comments)
• unexpected indentation (standard:indent)
• excessive line lengths (standard:max-line-length)
• class naming (standard:class-naming)
• try catch spacing (standard:try-catch-finally-spacing)
• removal of underscores, capitalisation in fun names (standard:function-naming)
• filename not matching class name (standard:filename)
• backing property used with private property (standard:backing-property-naming)
• lexicopgraphical import ordering (standard:import-ordering)

Tests performed (required)
Tested 'app' profile on Virtual Device (Pixel_7_Pro) with API_35

Ran 'All Tests', failures reported, the same failures reported when executed on the unmodified codebase. Unsure if this is a configuration issue like user account or pre-existing issue with the unit tests.

• AboutActivityTest 9/9
• LoginActivityTest 3/3
• MainActivityTest 0/5
• ProfileActivityTest 0/1
• ReviewActivityTest 0/1

Screenshots (for UI changes only)

• None

[nicolas-raoul]

App still works as expected, I tried Nearby, notifications, Explore, uploading a few files.
I haven't checked all files but a sample looked good.

[nicolas-raoul]

Thanks a lot @tristan81 for the fast work!

Just being curious, what tool(s) did you use? :-)

[tristan81]

Thanks a lot @tristan81 for the fast work!

Just being curious, what tool(s) did you use? :-)

nothing ground breaking I used the latest version of ktlint, 1 round of autoformat (ktlint --format), then I outputed the remaining errors to an Excel workbook and just ticked them off one by one.