Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #5832: Navigation Banner Appears in Media Details Screen #5839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes Issue #5832: Navigation Banner Appears in Media Details Screen #5839

wants to merge 2 commits into from
+27 −8

Commits on Sep 27, 2024

  1. MediaDetailFragment.java: add helper method to retrieve ContributionF… 

    …ragment instance

Before this commit, there was no easy way to check for and retrieve the ContributionFragment instance that
was either the parent or grandparent (parent's parent) fragment. A complicated if check was required to
retrieve it.

After this commit, there is a simple helper method which will retrieve the ContributionFragment instance.
Existing code can now be replaced by calling this method.
    @Jason-Whitmore
    Jason-Whitmore committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    408f5a3 View commit details
    Browse the repository at this point in the history

  2. MediaDetailFragment.java: replace code that is meant to hide nearby card 

    Before this commit, code would attempt to find and hide the nearby card that would appear
when the user was looking at media details. However, this code did not work.

After this commit, the old code has been replaced with code that correctly hides the
nearby card. Also, this new code uses a helper method call and is overall easier to read.
    @Jason-Whitmore
    Jason-Whitmore committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4c88759 View commit details
    Browse the repository at this point in the history