Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load dependencies before displaying protocol #621

Open
bryfox opened this issue Aug 1, 2018 · 4 comments
Open

Load dependencies before displaying protocol #621

bryfox opened this issue Aug 1, 2018 · 4 comments

Comments

@bryfox
Copy link
Contributor

bryfox commented Aug 1, 2018

There are some cases where we may want to ensure that dependencies (other than protocol.json) are loaded before a protocol is considered "loaded" and ready for display.

@jthrilly
Copy link
Member

This may also impact large image/video assets. For example, the looped video with sound in the development protocol takes several seconds to load, even on fast devices.

@jthrilly
Copy link
Member

Does anybody have any thoughts on a technical implementation for this?

@bryfox
Copy link
Contributor Author

bryfox commented Sep 14, 2018

We won't want to load large assets into memory; we should let the browser handle natively (e.g., streaming video from disk).

Workers should be small, and are potentially required on every interface, so preloading makes sense. I've been assuming external data will be small enough to fit in memory, but if that's not necessarily the case, then we wouldn't include that here (and we may need to reconsider how we cache in #413).

Implementation: we can make this part of the protocol loading epic; once all dependencies are met, then PROTOCOL_LOADED is dispatched.

@jthrilly
Copy link
Member

Would the streaming method resolve the issues we currently see with a delay when initially showing a large asset, do you think?

@jthrilly jthrilly added this to the Beta-stretch milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants