Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript typings need to be updated to support AWS SDK v3 #39

Open
raedatoui opened this issue Sep 25, 2023 · 0 comments
Open

Typescript typings need to be updated to support AWS SDK v3 #39

raedatoui opened this issue Sep 25, 2023 · 0 comments

Comments

@raedatoui
Copy link

raedatoui commented Sep 25, 2023 •
edited
Loading

This PR #34 didnt update the typings file, which still has

const AWS = require("aws-sdk");
export const ConnectorFactory: (awsConfig: AWS.Config) => Connector;

Maybe it's time to drop support to the SDK v2 in the next major release?
@raedatoui raedatoui changed the title Typescript typings need to be update to support AWS SDK v3 Typescript typings need to be updated to support AWS SDK v3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raedatoui