Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict validation hangs with a test case #19

Open
prabhu opened this issue Jul 24, 2024 · 1 comment
Open

Strict validation hangs with a test case #19

prabhu opened this issue Jul 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@prabhu
Copy link

prabhu commented Jul 24, 2024

We recently noticed that strict validation never completes for urls containing ${ with 3 or more levels in path. Below is an example:

https://github.com/apache/maven-resolver/tree/${project.scm.tag}

It works for below:

https://github.com/apache/${project.scm.tag}
# Takes over 30 seconds
https://github.com/apache/maven-resolver/${project.scm.tag}
@rubensworks
Copy link
Member

The regex is probably running into some issues for that case.
We should look into optimizing the regex.
(Definitely open to PRs!)

@rubensworks rubensworks added the bug Something isn't working label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants