Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify partials not in use #604

Open
benjaminwood opened this issue Sep 10, 2018 · 1 comment
Open

Identify partials not in use #604

benjaminwood opened this issue Sep 10, 2018 · 1 comment
Assignees

Comments

@benjaminwood
Copy link
Member

benjaminwood commented Sep 10, 2018

Related to removing prototype - @scytacki suggested that identifying partials that are not being rendered would be helpful. Without coverband in production this will be best-effort as some partial names may be constructed dynamically.

@benjaminwood
Copy link
Member Author

benjaminwood commented Sep 17, 2018

Spoke with @tjchambers and we agree that the only reasonable way to approach this is dynamically. Searching statically will not render results that we can depend on.

Given that test coverage is not comprehensive and also that views are not rendered in the test suite, I suggest that we wait until we can use coverband in production to identify which partials are not in use. It'll be real easy at that point :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants