Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to official version 3.4.1 from branch 3.4 #45

Open
1 task done
tegarriott opened this issue Aug 5, 2024 · 3 comments · May be fixed by #46
Open
1 task done

Update to official version 3.4.1 from branch 3.4 #45

tegarriott opened this issue Aug 5, 2024 · 3 comments · May be fixed by #46
Labels

Comments

@tegarriott
Copy link

tegarriott commented Aug 5, 2024

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

On the eigen project, on branch 3.4, a commit for an update to version 3.4.1 was pushed, but this release was not tagged: https://gitlab.com/libeigen/eigen/-/commit/bae907b8f6078b1df290729eef946360315bd312

This release fixes a crash from this issue: https://gitlab.com/libeigen/eigen/-/merge_requests/1318

The recipe should be updated so this sha is pointed to so that the bug is fixed.

Installed packages

N/A

Environment info

N/A
@tegarriott tegarriott added the bug label Aug 5, 2024
@tegarriott tegarriott linked a pull request Aug 5, 2024 that will close this issue
5 tasks
@traversaro
Copy link
Contributor

We can't publish a 3.4.1 release until Eigen upstream itself releases it, as it is confusing for users if we make up releases and as otherwise what we will do when 3.4.1 is actually tagged?

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

@traversaro
Copy link
Contributor

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

The fix seems minimal, did you tried to apply it to 3.4.0?

@tegarriott
Copy link
Author

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

The fix seems minimal, did you tried to apply it to 3.4.0?

Will look into making a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants