-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tt-metalium #28854
base: main
Are you sure you want to change the base?
Adding tt-metalium #28854
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tt-metalium/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12927119653. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tt-metalium/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12944803893. Examine the logs at this URL for more detail. |
@h-vetinari would you be willing to review this? (Pretty please) The C++ code builds. I still need to iron out the python wheel generation and installation, but I believe all pieces are in place (just might be missing some python module dependencies). |
extra: | ||
recipe-maintainers: | ||
- blozano-tt | ||
- afuller-TT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm I am willing to be listed here. ✅
recipes/tt-metalium/meta.yaml
Outdated
version: {{ version }} | ||
|
||
source: | ||
- url: https://github.com/tenstorrent/tt-metal/releases/download/v{{ version }}-rc13/tt-metalium.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is using an RC (rc13
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am putting a lot of fixes into main to support this effort. I needed a very recent version of the code. We upload release candidates daily. We cut releases very rarely.
@conda-forge-admin , please relint |
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
As a meta-comment, I note the |
I'll keep it in mind! The common scenario we currently have is However, I have heard of a few efforts where the host is desired to be |
- python | ||
- numactl | ||
- libhwloc | ||
- libzlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you shouldn't add libzlib
at runtime, but put zlib
into host. Your commit message in ed3b681 says "RISCV compiler binaries" - where are these coming from and how do they come into play?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released binaries are fetched At tt-metalium build time. They are used to compile some static riscv firmware.
They are used at runtime to jit compile kernel code that is later launched on riscv accelerators.
The compiler binaries are dynamically linking some things.
I realize after you highlight it, that this is not ideal for conda packaging.
Source is here:
https://github.com/tenstorrent/sfpi
I guess I could ask them to static link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I’d like to avoid creating a conda package for that repo…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released binaries are fetched [at] build time. They are used to compile some static riscv firmware.
They are used at runtime to jit compile kernel code that is later launched on riscv accelerators.
Given that we don't have riscv support at the moment, I'd say this is probably alright for now, but still CC @conda-forge/core if someone has other opinions.
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@h-vetinari I finally got the recipe building locally. I had to adjust Python packaging in setup.py. I removed the Python version constraint so that all versions are built. Now I see that the conda recipe build is killed because of how long it takes to build. It takes 2.5 hours to build for a single version of Python on the Azure infra. (I think it’s using a single core. It usually takes 5 minutes on our powerful build machines with many cores and copious ram. What are my options here? Limit the number of supported Python versions? Cleanup the C++ code to at least halve the build time? Adjust the recipe to ingest a prebuilt artifact? That’s all I can think of. |
The best approach is to only build for one python version in staged recipes for now (by adding |
Things are now in good shape. I have two action items left.
Will update when completed |
At the bottom of the logs there's a fold out section called |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).