Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixi-diff #28929

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add pixi-diff #28929

wants to merge 2 commits into from

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jan 25, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 25, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pixi-diff/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/pixi-diff/recipe.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12963670111. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pixi-diff/recipe.yaml) and found it was in an excellent condition.

@pavelzw
Copy link
Member Author

pavelzw commented Jan 25, 2025

failing on windows with

│ │ Error: `cargo metadata` exited with an error:     Updating crates.io index
 │ │     Updating git repository `[https://github.com/pavelzw/pixi`](https://github.com/pavelzw/pixi%60)
 │ │ error: failed to get `pixi` as a dependency of package `pixi-diff v0.0.2 (%SRC_DIR%)`
 │ │ Caused by:
 │ │   failed to load source for dependency `pixi`
 │ │ Caused by:
 │ │   Unable to update https://github.com/pavelzw/pixi?branch=diff-public#8a8f8d42
 │ │ Caused by:
 │ │   path too long: '%BUILD_PREFIX%/.cargo/git/checkouts/pixi-f27cc74e62c451b3/8a8f8d4/crates/pixi_build_frontend/src/protocols/builders/conda_build/snapshots/pixi_build_frontend__protocols__builders__conda_build__protocol__test__conda-render__microarch-level.txt.snap'; class=Filesystem (30)
 │ │ × error Script failed with status 1
 │ │ × error Work directory: 'D:\bld\bld\rattler-build_pixi-diff_1737796743\work'
 │ │ × error To debug the build, run it manually in the work directory (execute the `./conda_build.sh` or `conda_build.bat` script)

@pavelzw
Copy link
Member Author

pavelzw commented Jan 25, 2025

@conda-forge/help-rust any idea how to work around this? this is due to pixi-diff having a git dependency: https://github.com/pavelzw/pixi-diff/blob/c7f7eb0a7ec33b8e2280a1b2182505c585a587d4/Cargo.toml#L19

@pavelzw
Copy link
Member Author

pavelzw commented Jan 25, 2025

@conda-forge/help-rust this is ready for review

@pavelzw pavelzw marked this pull request as ready for review January 25, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants