Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tensorizer #28932

Merged
merged 11 commits into from
Jan 25, 2025
Merged

Add tensorizer #28932

merged 11 commits into from
Jan 25, 2025

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 25, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/tensorizer/recipe.yaml:

  • ❌ The recipe must have a build/number section.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12962182847. Examine the logs at this URL for more detail.

@maresb
Copy link
Contributor Author

maresb commented Jan 25, 2025

Blocked by #28930

@maresb maresb mentioned this pull request Jan 25, 2025
10 tasks
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found it was in an excellent condition.

@maresb maresb closed this Jan 25, 2025
@maresb maresb reopened this Jan 25, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/tensorizer/recipe.yaml:

  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/tensorizer/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12966431214. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tensorizer/recipe.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12966688554. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorizer/recipe.yaml) and found it was in an excellent condition.

@maresb maresb marked this pull request as ready for review January 25, 2025 18:05
@maresb
Copy link
Contributor Author

maresb commented Jan 25, 2025

@conda-forge/help-python, ready for review!

The original repo has a CMakeLists.txt so I figured this was compiled, but it seems that they're just using it for some protobuf code generation. This is noarch, as evidenced by the any wheel on PyPI. And just to be sure, with a few minor exceptions the test suite succeeds.

@ocefpaf ocefpaf merged commit a53ad4b into conda-forge:main Jan 25, 2025
7 checks passed
@maresb maresb deleted the tensorizer branch January 25, 2025 18:14
@maresb maresb mentioned this pull request Jan 25, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants