Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global skip does not work in multi-output recipe #4206

Open
h-vetinari opened this issue Mar 5, 2021 · 9 comments
Open

Global skip does not work in multi-output recipe #4206

h-vetinari opened this issue Mar 5, 2021 · 9 comments
Labels
stale::recovered [bot] recovered after being marked as stale

Comments

@h-vetinari
Copy link
Contributor

h-vetinari commented Mar 5, 2021

Since this issue was reopened: the issue is that adding skip: true # [something] in a multi-output recipe does not translate to a skip for all outputs (which is why conda-smithy will keep generating jobs).

There's an argument to be made that this is somewhat correct based on the fact that the "global" output is not really all that special from the POV of conda. For example, if an output uses a script: ... variable, then it's conceivable that an output could still be produced even without running build.sh.

I don't know of any multi-output recipes though that are this clearly separated. In most cases, multi-output recipes are chosen at all because there's some substantial overlap in what needs to happen between the different outputs, and then the "global" build step becomes a hard requirement, without which trying to build makes no sense (hence the expectation that skipping it should be a clear enough signal to give up).

The - somewhat annoying - workaround is to add skip: true # [something] to every single output.


Previously:

In conda-forge/modin-feedstock#13, I updated skip: true # [py<37], since upstream isn't compatible with 3.6 anymore.

While trying to turn this recipe into a multi-output version, rerendering cause the 3.6 CI jobs to reappear (even though the build is skipped, so CI should stay green).

At first I thought this was a conda smithy issue, but was advised there that this is actually coming from conda render under the hood, and to raise an issue here.

@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 21, 2023
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Jun 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Jun 21, 2023
@leofang
Copy link

leofang commented Jan 19, 2024

Can we please reopen this issue? We hit this issue in skipping PY38 in a conda-forge feedstock. I think it is a waste of the CI resources to launch pipelines and yet do nothing.

cc: @kenodegard

@jakirkham jakirkham reopened this Jan 20, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to 🏗️ In Progress in 🧭 Planning Jan 20, 2024
@jakirkham jakirkham removed stale [bot] marked as stale due to inactivity stale::closed [bot] closed after being marked as stale labels Jan 20, 2024
@h-vetinari h-vetinari changed the title Skipping python 3.6 still creates CI job in multi-output recipe BUG: Global skip in multi-output recipe does not work Jan 20, 2024
@h-vetinari h-vetinari changed the title BUG: Global skip in multi-output recipe does not work Global skip does not work in multi-output recipe Jan 20, 2024
@h-vetinari
Copy link
Contributor Author

Given that this was reopened, I updated the OP and the title. Relevant snippet:

The - somewhat annoying - workaround is to add skip: true # [something] to every single output.

@leofang
Copy link

leofang commented Jan 20, 2024

Even adding skip to every single output does not work.

@h-vetinari
Copy link
Contributor Author

Every single output, including the "global" one. I've never seen CI jobs created once every possible output was skipped.

@jakirkham
Copy link
Member

Yes that is what Leo had tried earlier. Reference meta.yaml for discussion

@jakirkham
Copy link
Member

jakirkham commented Jan 20, 2024

Think an important point to note is once we added python in the top-level requirements/host, the skip (and conda smithy rerender in our case) worked

So think it is some combination of top-level requirements and skip that make the difference. We could probably poke at that example more to learn what is going on

Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jan 20, 2025
@h-vetinari
Copy link
Contributor Author

Even though I know how to work around this now, it still feels pointless. A package-level skip should also skip all the outputs IMO.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale::recovered [bot] recovered after being marked as stale
Projects
Archived in project
Development

No branches or pull requests

3 participants