Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setters to PrefixRecord and add methods to write back a PrefixRecord to JSON #631

Open
iamthebot opened this issue Apr 26, 2024 · 5 comments
Open

Add setters to PrefixRecord and add methods to write back a PrefixRecord to JSON #631

iamthebot opened this issue Apr 26, 2024 · 5 comments
Labels
help wanted Extra attention is needed python-bindings

Comments

@iamthebot
Copy link
Contributor

Currently, in py-rattler a PrefixRecord is essentially read-only. However, to facilitate use cases where we want to manipulate a record (and optionally write it back) we'd also want setters.
@baszalmstra baszalmstra added the help wanted Extra attention is needed label May 6, 2024
@baszalmstra
Copy link
Collaborator

Id be happy to accept contributions. 😄

@iamthebot
Copy link
Contributor Author

@baszalmstra looks like #663 is now in progress for this.

@jaimergp
Copy link
Contributor

Also interested in this. Right now I have to dump to a temporary JSON just to instantiate new rattler.PrefixRecord objects from Python.

@iamthebot
Copy link
Contributor Author

@Wackyator need help finalizing #663 ?

@baszalmstra
Copy link
Collaborator

I spoke with @Wackyator and I think its fine to take it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed python-bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaimergp @baszalmstra @iamthebot