Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the MatchSpec.channel a NamedChannelOrUrl #796

Open
ruben-arts opened this issue Jul 25, 2024 · 2 comments
Open

Make the MatchSpec.channel a NamedChannelOrUrl #796

ruben-arts opened this issue Jul 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ruben-arts
Copy link
Collaborator

Currently the channel is a full Channel object which contains the configuration for the base url. E.g. conda-forge gets interpreted by default as https://conda.anaconda.org/conda-forge.

This configuration shouldn't matter for a match spec but only while solving. After that, the channel is available on the package record.

I propose to move to the NamedChannelOrUrl type which allows for evaluation of the channel configuration after the parsing is done. This would simplify parsing and avoid miss interpretation of a channel before the configuration is set correctly.

@ruben-arts ruben-arts added the enhancement New feature or request label Jul 25, 2024
@baszalmstra
Copy link
Collaborator

The downside is that you would then need a ChannelConfig when calling matches..

@ruben-arts
Copy link
Collaborator Author

What about having a RenderedMatchspec that contains this "full" channel. Where you would need to do the conversion.

Also I think you could still match a NamedChannelOrUrl on a Channel based on the info you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants