PXY-860 Add metadata to Plugins #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fteychene
reviewed
Jul 11, 2023
|
|
||
| default List<String> examples() { | ||
| try { | ||
| return List.of(resourceAsString("/META-INF/services/example.json")); |
There was a problem hiding this comment.
Configuration is done by yaml from configuration file in gateway. Maybe we should provide multiple configuration files.
Also if multiple plugins (let's say 2) are loaded in the classpath and each ref a /META-INF/services/example.json what happen ?
There was a problem hiding this comment.
You're right, addressed here: 84033e0
|
@fteychene good? |
|
@framiere - what's the behaviour for;
|
|
If the purpose of this is for the UI then it must contain an example JSON, otherwise it's useless imo. Can we do another PR that covers this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to be able to give more context for each plugin.
Any UI wanted to surface these plugins will need a way to get some metadata about them.