Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS | Use hex encoding rather than base64 in parsed claims #372

Open
Xynnn007 opened this issue Apr 19, 2024 · 1 comment
Open

AS | Use hex encoding rather than base64 in parsed claims #372

Xynnn007 opened this issue Apr 19, 2024 · 1 comment

Comments

@Xynnn007
Copy link
Member

We are using hex in [tdx claims](https://github.com/confidential-containers/trustee/blob/main/attestation-service/verifier/src/tdx/claims.rs#L67, sgx claims, azure vTPM claims. Also base64 in SNP.

I suggest that we should use a common encoding, which would make the policy writing work easier.

@larrydewey
Copy link
Contributor

I agree, we should unify on a single encoding practice. If I remember correctly, I believe base64 was selected because of how the qemu interfaces were defined, though I could be remembering incorrectly. @fitzthum do you happen to know off the top of your head?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants