Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When SSLCACertificate is empty an error is logged and it fails to start - doesn't match with docs (or other code) #895

Open
dqwork opened this issue Oct 11, 2024 · 0 comments

Comments

@dqwork
Copy link

dqwork commented Oct 11, 2024

The docs say for
SSLCACertificate
If not specified, then all certificates installed on the computer's certificate store (under "Trusted Root Certificates") are used. The certificate can be loaded either from a file or from the current user's personal certificate store.
https://quickfixn.org/tutorial/configuration.html#ssl:~:text=If%20not%20specified%2C%20then%20all%20certificates%20installed%20on%20the%20computer%27s%20certificate%20store%20(under%20%22Trusted%20Root%20Certificates%22)%20are%20used.%20The%20certificate%20can%20be%20loaded%20either%20from%20a%20file%20or%20from%20the%20current%20user%27s%20personal%20certificate%20store.

However you can see here

if (string.IsNullOrEmpty(_socketSettings.CACertificatePath)) {

that if its empty an error is logged and it returns false, ended the cert finding process.

It seems that along with the docs indicating this is wrong, comments on other places in the code indicate this too

// If CA Certificate is specified then validate against the CA certificate, otherwise it is validated against the installed certificates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant