Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows binaries missing from the release page #99

Open
rgl opened this issue Mar 21, 2020 · 12 comments
Open

Windows binaries missing from the release page #99

rgl opened this issue Mar 21, 2020 · 12 comments

Comments

@rgl
Copy link

rgl commented Mar 21, 2020

Description

At the https://containerd.io/ homepage there's this paragraph:

containerd is available as a daemon for Linux and Windows.

But at the release page (e.g. https://github.com/containerd/containerd/releases/tag/v1.3.3) there is only the linux binaries (e.g. containerd-1.3.3.linux-amd64.tar.gz).

Describe the results you expected:

A windows binary in the release page.

@estesp
Copy link
Member

estesp commented Mar 24, 2020

Who is building and/or releasing containerd for Windows? @Random-Liu or @jterry75 do you all know?

@marosset
Copy link

marosset commented May 4, 2020

@kevpar Can you help look into this?

@kevpar
Copy link
Member

kevpar commented May 4, 2020

We (Microsoft) don't currently release containerd for Windows. @estesp what would be needed to add a Windows build to the containerd release process?

@marosset
Copy link

marosset commented May 4, 2020

I noticed there are windows binaries nightly builds of containerd at https://github.com/containerd/containerd/actions/runs/94784795
It would be good to include them in for releases as well.

@marosset
Copy link

/cc @cpuguy83

@cpuguy83
Copy link
Member

Should we build hcs shim along with it?

@seemethere
Copy link

I can help with this, how are assets uploaded to the release in the first place?

I couldn't find any references in https://github.com/containerd/release-tool

@dmcgowan
Copy link
Member

dmcgowan commented May 15, 2020

The release-tool just generates the tag and release notes. Travis doing the builds today. Since Travis is broken I have been building locally and pushing up. We hope to get these moved over to Github actions by 1.4 final. Hopefully building windows and linux, and arm64 but that is a stretch goal right now.

@cpuguy83
Copy link
Member

cpuguy83 commented Jun 2, 2020

Releases are now triggered by GH action, and Windows builds are included.
Currently this is only on 1.4 beta1.

@cpuguy83
Copy link
Member

v1.3.5 also includes Windows binaries now.

@khatrig
Copy link

khatrig commented Aug 7, 2021

Shouldn't the windows binaries be available under Downloads on https://containerd.io?

@estesp estesp transferred this issue from containerd/containerd Aug 18, 2021
@estesp
Copy link
Member

estesp commented Aug 18, 2021

When the website was designed we didn't have Windows support; I just moved this issue to the website repo and am re-opening it so we can fix this now that we have official Windows releases.

@estesp estesp reopened this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants