From bae899737b48ba9e9932f4756411ce81e190971d Mon Sep 17 00:00:00 2001 From: jiaxiao zhou Date: Thu, 13 Jun 2024 18:56:58 +0000 Subject: [PATCH] revert the alert-threshold to %130 Signed-off-by: jiaxiao zhou --- .github/workflows/benchmarks.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 355475d6f..8a438eae8 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -4,10 +4,6 @@ on: schedule: - cron: '0 0 * * *' # Runs daily at midnight pull_request: - -permissions: - contents: write # Required for commit comment for alert - pull-requests: write # Required for commit comment for alert jobs: benchmark: @@ -40,10 +36,11 @@ jobs: name: Criterion.rs Benchmark tool: 'cargo' output-file-path: output.txt - # GitHub API token to make a commit comment github-token: ${{ secrets.GITHUB_TOKEN }} - # Show alert with commit comment on detecting possible performance regression - alert-threshold: '1%' + # my experimental local benchmarking seems to have a 20% margin of error. + # So I set the alert threshold to 130% of the previous benchmark result. + # If the current benchmark result is more than 130% of the previous benchmark result, it will fail. + alert-threshold: '130%' fail-on-alert: true alert-comment-cc-users: '@runwasi-committers' # Enable Job Summary