Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Performance issue related to logging in shim #249

Open
jsturtevant opened this issue Mar 5, 2024 · 1 comment
Open

Possible Performance issue related to logging in shim #249

jsturtevant opened this issue Mar 5, 2024 · 1 comment
Labels
Stale

Comments

@jsturtevant
Copy link
Contributor

There was a report that we saw a speed up in runwasi after turning logging off. #247 makes logging configurable but we should investigate the report:

        I _suspect_ that the performance issues have more to do with mutex contention in `FifoLogger`, but I haven't done any analysis to confirm.

Originally posted by @lann in #247 (comment)
@jsturtevant jsturtevant mentioned this issue Mar 5, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsturtevant