Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-spec conversion does not follow current OCI spec #19459

Open
mtrmac opened this issue Jul 31, 2023 · 5 comments
Open

runtime-spec conversion does not follow current OCI spec #19459

mtrmac opened this issue Jul 31, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. stale-issue

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 31, 2023

Feature request description

https://github.com/opencontainers/image-spec/blob/main/conversion.md is fairly prescriptive about various image-spec fields that should be propagated to runtime-spec data, many as annotations.

From a (fairly brief and very ignorant) search of the Podman codebase, it seem that this is not currently happening.

I have absolutely no idea whether this makes any difference in practice.

@mtrmac mtrmac added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2023
@vrothberg
Copy link
Member

@jakecorrenti, is that something you are interested in looking into (assuming you have time)? I think that's a great opportunity to dive into the image spec and how Podman uses it to create container specs.

@jakecorrenti
Copy link
Member

Sure, I'd love to take a look

@jakecorrenti
Copy link
Member

/assign

@giuseppe
Copy link
Member

giuseppe commented Aug 7, 2023

we need to be careful with what annotations are propagated into the runtime spec though there is an open PR to clarify the risk: opencontainers/image-spec#1061

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

A friendly reminder that this issue had no activity for 30 days.

@jakecorrenti jakecorrenti removed their assignment Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. stale-issue
Projects
None yet
Development

No branches or pull requests

4 participants