Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Copy feature #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Copy feature #96

wants to merge 2 commits into from

Conversation

stefanheimes
Copy link
Member

Add the first version of the copy feature.

Open tasks:

  • Add handler if the validation throws a error
  • Handle the error code in the widget better, stop saying there is a error and add the error to the text

Test with some more widgets

  • Select
  • Checkbox
  • Text
  • Date
  • Text-Area
  • Filepicker
  • Pagepicker

@stefanheimes
First version of copy
f0cd822 
- Rework the js and reactivate the copy function
- Copy the js code for create a new empty row and add some more information
- Update the ExecutePostActions and add a switch for create a empty row or make a copy
- Update the mcw widget to use some data for creating a new row instead of a empty one
@stefanheimes
Optimize the js
6e7c774 
- Restructure the code
- Reset some dead code and make it usable again
- Remove some bugs with thew new/old code
- Add all to the small files
@discordier
Copy link
Member

This is a follow up of #89 to fix #18

@discordier discordier linked an issue Nov 13, 2020 that may be closed by this pull request
add copy row #18
Open
@discordier discordier added the enhancement New feature or request label Nov 13, 2020
@zonky2 zonky2 modified the milestones: 3.4.9, 3.4.10 Nov 13, 2020
@Total-Reality
Copy link

It is possible to add the copy function already? It is okay if only select and checkbox fields are duplicated.
I think it is even better than before, because text fields seldom needs to be duplicated - so you always had to empty it manually after duplicating.

@zonky2
Copy link
Contributor

zonky2 commented Dec 4, 2020

It is possible to add the copy function already? It is okay if only select and checkbox fields are duplicated.
I think it is even better than before, because text fields seldom needs to be duplicated - so you always had to empty it manually after duplicating.

then it would be better to duplicate by default all fields with values and to exclude per eval parameters which

@stefanheimes stefanheimes modified the milestones: 3.4.10, 3.4.x Jan 26, 2021
@zonky2 zonky2 modified the milestones: 3.4.x, 3.5.x Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanheimes stefanheimes

@adziemba adziemba

Labels
enhancement New feature or request
Projects
None yet
Milestone
MAW/CCA 3.5.x
Development

Successfully merging this pull request may close these issues.

add copy row
5 participants
@stefanheimes @discordier @Total-Reality @zonky2 @adziemba