Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle !x.P.EnumMember as x.P != Enum.EnumMember #28

Open
ashmind opened this issue Feb 4, 2015 · 4 comments
Open

Handle !x.P.EnumMember as x.P != Enum.EnumMember #28

ashmind opened this issue Feb 4, 2015 · 4 comments

Comments

@ashmind
Copy link

ashmind commented Feb 4, 2015

Currently x.P.EnumMember generates x.P == Enum.EnumMember.
Which is awesome btw.

However !x.P.EnumMember generates !(x.P == Enum.EnumMember).
I think x.P != Enum.EnumMember would be better for that case.
@hazzik
Copy link

hazzik commented Feb 4, 2015

Shouldn't it be x.P.EnumMember.not?

@ashmind
Copy link
Author

ashmind commented Feb 4, 2015

It could be, but for not I don't actually use postfix as that's (how I think).not

@ashmind
Copy link
Author

ashmind commented Feb 4, 2015

So I suggest both should work in the same way.

@hazzik
Copy link

hazzik commented Feb 5, 2015

.not works and produces correct result:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hazzik @ashmind