Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass token to npm script anymore #187

Open
wintercounter opened this issue Jul 7, 2020 · 5 comments · May be fixed by #189
Open

Cannot pass token to npm script anymore #187

wintercounter opened this issue Jul 7, 2020 · 5 comments · May be fixed by #189

Comments

@wintercounter
Copy link

This started to happen with the recent updates. Until now this was working fine:

// package.json
{
    "scripts": {
        "release": "conventional-github-releaser -t"
    }
}

npm run release -- MY_TOKEN

But I started to get the following error:

C:\...es\conventional-github-releaser\node_modules\meow\node_modules\minimist-options\index.js:101
                                        throw new TypeError(`Expected "${key}" default value to be of type "${expectedType}", got ${prettyPrint(defaultType)}`);
                                        ^

TypeError: Expected "token" default value to be of type "string", got "undefined"
    at C:\node_modules\conventional-github-releaser\node_modules\meow\node_modules\minimist-options\index.js:101:12
    at Array.forEach (<anonymous>)
    at buildOptions (C:\node_modules\conventional-github-releaser\node_modules\meow\node_modules\minimist-options\index.js:64:23)
    at meow (C:\node_modules\conventional-github-releaser\node_modules\meow\index.js:136:18)
    at Object.<anonymous> (C:\node_modules\conventional-github-releaser\src\cli.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)

@cookiescrumbs
Copy link

I'm getting the same. I've locked to v3.1.3.

@Hartorn
Copy link

Hartorn commented Aug 24, 2020

We cannot even run in cli conventional-github-releaser --help, it breaks also with the same message

@thesmiley1
Copy link

I'm not sure about previous behavior, but I was able to work around the issue by supplying a CONVENTIONAL_GITLAB_RELEASER_TOKEN environment variable, even just a dummy one to get the help working, e.g.:

CONVENTIONAL_GITLAB_RELEASER_TOKEN=asdf conventional-gitlab-releaser --help

Obviously there is still a bug, though: it shouldn't take a dummy token to print the help documentation.

@carmanchris31
Copy link

Updating https://github.com/conventional-changelog/releaser-tools/blob/master/packages/conventional-github-releaser/src/cli.js#L50 should fix this:

-       default: process.env.CONVENTIONAL_GITHUB_RELEASER_TOKEN,
+       default: process.env.CONVENTIONAL_GITHUB_RELEASER_TOKEN || '',

@lvjiaxuan
Copy link

v3.1.5 still error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

6 participants