Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Pass Environmental Variables Into the Worker From the Factory #1729

Closed
klannon opened this issue Aug 31, 2017 · 2 comments
Closed

Comments

@klannon
Copy link

klannon commented Aug 31, 2017

See https://github.com/matz-e/lobster/issues/600, in particular @matz-e's last comment.

It would be nice to have some way to pass a list of environmental variables into the worker environment from the factory. Here is one example use case: Suppose the task uses an environmental variable to determine the squid proxy location. If you could tell each factory to set the environmental variable to the appropriate value, it would allow configure different factories for different resource environments (e.g. different squid servers).

@khurtado might also want to comment on whether I have the right idea here.

I know there's a lot of pressure with other deadlines, so no rush here. No work is stuck. I just wanted to file it before I forgot about it.

@dthain
Copy link
Member

dthain commented Aug 31, 2017

Should be pretty straightfoward, since the batch job interface has an explicit place to pass environment variables along to the underlying job.

@btovar btovar self-assigned this Aug 31, 2017
@dthain
Copy link
Member

dthain commented Sep 18, 2017

@nkremerh Please implement this one. Suggest that you allow the factory to have multiple arguments of the form --env X=Y that just add elements to JX dictionary, and then pass that through to batch_job_submit. (@btovar has plenty to do right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants