Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-custodial escrow example program is not working #9

Open
nickguo opened this issue Jul 20, 2023 · 0 comments
Open

Non-custodial escrow example program is not working #9

nickguo opened this issue Jul 20, 2023 · 0 comments

Comments

@nickguo
Copy link

nickguo commented Jul 20, 2023

The tests for the non-custodial escrow example program are now out of date against the latest @solana/spl-token package.

Also, there is a superficial mistake here https://github.com/coral-xyz/anchor-by-example/blob/master/programs/non-custodial-escrow/tests/non-custodial-escrow.ts#L112 where the test should instead use program.methods.accept() per the anchor rust program design.

Could I submit a PR to fix this example? The page here would also need to be updated. https://examples.anchor-lang.com/docs/non-custodial-escrow
Asking in advance before I make the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant