Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just a Typescript bug [not too serious] #4342

Open
felixoder opened this issue Sep 16, 2024 · 2 comments · May be fixed by #4344
Open

Just a Typescript bug [not too serious] #4342

felixoder opened this issue Sep 16, 2024 · 2 comments · May be fixed by #4344

Comments

@felixoder
Copy link

So in the backpack/web/components/AppNoLink.tsx
image
This Image says that Type '"100px"' is not assignable to type 'SafeNumber'

  1. I think we should remove the *px from there that would be a ez fix.
@Keyur3766 Keyur3766 linked a pull request Sep 19, 2024 that will close this issue
Open
@rajeshchauhan1426
Copy link

<Image
alt="logo"
src={iconUrl}
blurDataURL="/brands/aurory.jpg" //TODO: fix me
placeholder="blur"
quality={50}
width={100} // Change this line
/> try this out

@felixoder
Copy link
Author

@rajeshchauhan1426 yupp that's correct but someone already fixes that and raised a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typescript error fixed for Image component Keyur3766/backpack
2 participants
@rajeshchauhan1426 @felixoder