Nose software1 #12

nihinihikun · 2023-12-29T14:46:03Z

以下確認して消してからプルリク出してください

各項目は今回のプロジェクトでのGitHubの使い方を参考に書く
画面右のreviewrを @771_8bit に，assigneeを自分に設定する
作業中のメモはプルリク上に残す
レビューができる状態になったらレビュー時を参考にコメントを書く

概要

ノーズ各センサ類使用テスト

背景

ノーズのセンサ類等おためし

変更範囲

各センサの動作，統合まではこのプルリクで，CAN関連は別のプルリクで

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

Nose/source/MCP342X-master/MCP342X.h|127| #endif line should be "#endif // NOSE_SOURCE_MCP342X_MASTER_MCP342X_H_" [build/header_guard] [5]
Nose/source/MCP342X-master/MCP342X.h|1| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|24| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|42| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|43| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|45| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|46| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|47| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|48| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|49| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|50| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|51| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|52| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|53| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|54| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|58| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|59| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|63| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|64| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|66| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|67| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|68| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|69| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|70| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|73| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|77| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|78| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|79| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|80| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|81| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|82| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|86| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|87| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|88| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|89| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|94| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|100| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Nose/source/MCP342X-master/MCP342X.h|101| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/MCP342X-master/MCP342X.h|104| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|107| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|107| Lines should be <= 50 characters long [whitespace/line_length] [2]
Nose/source/MCP342X-master/MCP342X.h|112| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/MCP342X-master/MCP342X.h|124| Tab found; better to use spaces [whitespace/tab] [1]

Nose/source/MCP342X-master/MCP342X.cpp

github-actions · 2023-12-29T14:46:29Z

Nose/source/MCP342X-master/MCP342X.cpp

+  }
+
+  if(Wire.requestFrom((uint8_t) devAddr, (uint8_t) 4) == 4) {
+    ((char*)dataPtr)[3] = Wire.read();


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2023-12-29T14:46:29Z

Nose/source/MCP342X-master/MCP342X.cpp

+
+  if(Wire.requestFrom((uint8_t) devAddr, (uint8_t) 4) == 4) {
+    ((char*)dataPtr)[3] = Wire.read();
+    ((char*)dataPtr)[2] = Wire.read();


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2023-12-29T14:46:29Z

Nose/source/MCP342X-master/MCP342X.cpp

+  if(Wire.requestFrom((uint8_t) devAddr, (uint8_t) 4) == 4) {
+    ((char*)dataPtr)[3] = Wire.read();
+    ((char*)dataPtr)[2] = Wire.read();
+    ((char*)dataPtr)[1] = Wire.read();


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

Nose/source/MCP342X-master/MCP342X.h

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

Nose/source/MCP342X-master/MCP342X.h|101| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/MCP342X-master/MCP342X.h|107| Tab found; better to use spaces [whitespace/tab] [1]
Nose/source/MCP342X-master/MCP342X.h|112| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/MCP342X-master/MCP342X.h|124| Tab found; better to use spaces [whitespace/tab] [1]

Nose/source/MCP342X-master/MCP342X.h

github-actions · 2023-12-30T04:42:56Z

Nose/source/MCP342X-master/MCP342X.h

+    public:
+        MCP342X();
+        MCP342X(uint8_t address);
+


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:42:57Z

Nose/source/MCP342X-master/MCP342X.h

+        // Start a conversion
+        bool startConversion(void);
+        bool startConversion(uint8_t channel);
+


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

771-8bit · 2023-12-30T04:51:23Z

@nihinihikun
こんな感じのディレクトリにしてほしいです

24th-ise/
- test/Nose/ ノーズのセンサ類等おためし
- docs/Nose/ ノーズのメモ
- Nose/Nose.ino ノーズの本番用プログラム

771-8bit · 2023-12-30T04:53:16Z

@nihinihikun MCP342XってArduino IDEのライブラリマネージャー経由じゃなくてローカルに落としてるの理由ある？

771-8bit · 2023-12-30T04:56:23Z

Arduinoのライブラリに登録されてるのはこっちで
https://github.com/stevemarple/MCP342x/
https://www.arduino.cc/reference/en/libraries/mcp342x/

にひが使ってるのはこっちっぽい
https://github.com/uChip/MCP342X/

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

Nose/source/mcp3421_2/mcp3421_2.ino|31| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|32| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|33| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|36| Missing space after , [whitespace/comma] [3]
Nose/source/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Nose/source/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
Nose/source/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
Nose/source/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
Nose/source/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
Nose/source/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Nose/source/nose1/nose1.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose1/nose1.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
Nose/source/nose1/nose1.ino|29| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose1/nose1.ino|45| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|46| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|47| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|49| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|51| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|53| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|54| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose1/nose1.ino|58| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|63| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|64| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose1/nose1.ino|65| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose1/nose1.ino|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose1/nose1.ino|66| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose1/nose1.ino|69| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|71| Missing space after , [whitespace/comma] [3]
Nose/source/nose1/nose1.ino|76| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose1/nose1.ino|79| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose_timer/nose_timer.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
Nose/source/nose_timer/nose_timer.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose_timer/nose_timer.ino|56| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|59| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|63| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|68| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|69| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|70| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|71| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/nose_timer/nose_timer.ino|71| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|74| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|76| Missing space after , [whitespace/comma] [3]
Nose/source/nose_timer/nose_timer.ino|81| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|84| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/nose_timer/nose_timer.ino|91| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Nose/source/test/bme280test/bme280test.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/bme280test/bme280test.ino|9| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
Nose/source/test/bme280test/bme280test.ino|21| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
Nose/source/test/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|12| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|18| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|26| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|26| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|34| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|36| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Nose/source/test/mcp3421check_samd/mcp3421check_samd.ino|36| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Nose/source/test/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2023-12-30T04:59:21Z

Nose/source/BME_high_rate/BME_high_rate.ino

+
+#define SEALEVELPRESSURE_HPA (1013.25)
+
+Adafruit_BME280 bme; 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:59:21Z

Nose/source/BME_high_rate/BME_high_rate.ino

+
+Adafruit_BME280 bme; 
+
+unsigned long delayTime;


[cpplint] _{reported by reviewdog 🐶}
Use int16/int64/etc, rather than the C type long [runtime/int] [4]

github-actions · 2023-12-30T04:59:22Z

Nose/source/BME_high_rate/BME_high_rate.ino

+}
+
+
+void loop() { 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:59:22Z

Nose/source/BME_mcp3421/BME_mcp3421.ino

+
+#define SEALEVELPRESSURE_HPA (1013.25)
+
+Adafruit_BME280 bme; 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:59:22Z

Nose/source/BME_mcp3421/BME_mcp3421.ino

+Adafruit_BME280 bme; 
+MCP342X myADC;
+
+unsigned long delayTime;


[cpplint] _{reported by reviewdog 🐶}
Use int16/int64/etc, rather than the C type long [runtime/int] [4]

github-actions · 2023-12-30T04:59:23Z

Nose/source/MCP342X-master/Examples/ReadLoop/ReadLoop.ino

+  myADC.getResult(&result);
+
+  Serial.println(result, HEX);
+


[cpplint] _{reported by reviewdog 🐶}
Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]

github-actions · 2023-12-30T04:59:23Z

Nose/source/mcp3421_2/mcp3421_2.ino

+void setup() {
+  Wire.begin();  // join I2C bus
+//   TWBR = 12;  // 400 kHz (maximum)
+  Serial.begin(9600); // Open serial connection to send info to the host    


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:59:23Z

Nose/source/mcp3421_2/mcp3421_2.ino

+  byte bytes[4];
+  myADC.startConversion();
+  myADC.getResult(&result);
+  ConvertToVoltage(&result,&voltage);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2023-12-30T04:59:23Z

Nose/source/mcp3421_2/mcp3421_2.ino

+
+  Serial.print("voltage:");
+  Serial.println(voltage);
+}  


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-30T04:59:24Z

Nose/source/mcp3421_2/mcp3421_2.ino

+  Serial.print("voltage:");
+  Serial.println(voltage);
+}  
+void ConvertToVoltage(int32_t* _result,double* voltage){


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

test/Nose/BME_mcp3421/BME_mcp3421.ino|73| Missing space after , [whitespace/comma] [3]
test/Nose/BME_mcp3421/BME_mcp3421.ino|74| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/BME_mcp3421/BME_mcp3421.ino|78| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/BME_mcp3421/BME_mcp3421.ino|81| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/bme280test/bme280test.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/bme280test/bme280test.ino|9| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/bme280test/bme280test.ino|21| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|10| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|24| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_2/mcp3421_2.ino|28| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_2/mcp3421_2.ino|31| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|32| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|33| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|36| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|12| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|18| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|26| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|26| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|34| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|36| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|36| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|9| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|23| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|38| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|40| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|66| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|68| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|69| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|71| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|73| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|74| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|78| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|81| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|10| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|24| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|28| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|31| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|32| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|36| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/nose1/nose1.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/nose1/nose1.ino|29| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|45| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|46| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|47| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|49| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|51| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|53| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|54| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|58| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|63| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|64| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|65| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|66| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|69| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|71| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|76| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|79| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2023-12-31T01:48:20Z

Nose/Nose.ino

+
+#define SEALEVELPRESSURE_HPA (1013.25)
+
+Adafruit_BME280 bme; 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

Nose/Nose.ino

github-actions · 2023-12-31T01:48:20Z

Nose/Nose.ino

+    add_repeating_timer_us(200000, TimerIsr, NULL, &st_timer);//シリアル出力1843200で200000us=5Hzを境にoverrun
+}
+
+void loop() { 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-31T01:48:20Z

Nose/Nose.ino

+    Serial.print(micros());
+    Serial.print(",");
+    // Serial.print(",barometic_pressure:");
+    Serial.print(barometic_pressure,10);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2023-12-31T01:48:21Z

Nose/Nose.ino

+    Serial.print(barometic_pressure,10);
+    // Serial.print("voltage:");
+    Serial.print(",");
+    Serial.println(voltage,10);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

test/Nose/BME_mcp3421/BME_mcp3421.ino

github-actions · 2023-12-31T01:48:22Z

test/Nose/BME_mcp3421/BME_mcp3421.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2023-12-31T01:48:22Z

test/Nose/BME_mcp3421/BME_mcp3421.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2023-12-31T01:48:23Z

test/Nose/BME_mcp3421/BME_mcp3421.ino

+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 
+  bytes[0] = (char)((*_result >> 24) & 0xFF); //ライブラリの関数内で8bit右シフトしたときに発生したものなので無視


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

test/Nose/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|12| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|18| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|26| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|26| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|34| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|36| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/mcp3421check_samd/mcp3421check_samd.ino|36| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|9| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/BME_high_rate/BME_high_rate.ino|23| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|31| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|38| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|40| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|66| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|68| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|69| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|71| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|73| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|74| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|78| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|81| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|10| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|24| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|28| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|31| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|32| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|36| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/nose1/nose1.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/nose1/nose1.ino|29| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|45| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|46| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|47| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|49| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|51| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|53| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|54| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|58| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|63| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|64| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|65| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|66| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|69| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|71| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|76| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|79| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2024-01-03T04:40:54Z

Nose/Nose.ino

+            GetBME280Data(&temperature, &barometic_pressure);
+            //CAN送信
+            #ifdef CAN_AVAIRABLE
+            CCP.uint32_to_device(CCP_nose_adc,voltage);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-03T04:40:54Z

Nose/Nose.ino

+            #ifdef CAN_AVAIRABLE
+            CCP.uint32_to_device(CCP_nose_adc,voltage);
+            CCP.float_to_device(CCP_nose_temperature, temperature);
+            CCP.float_to_device(CCP_nose_barometic_pressure, barometic_pressure);  


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-03T04:40:54Z

Nose/Nose.ino

+            CCP.float_to_device(CCP_nose_temperature, temperature);
+            CCP.float_to_device(CCP_nose_barometic_pressure, barometic_pressure);  
+            if(can_checkerflag){
+                CCP.string_to_device(CCP_nose_status,"OK");


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-03T04:40:54Z

Nose/Nose.ino

+    switch (CCP.id)
+    {
+    case CCP_EMST_mesure:
+        if(CCP.str_match("STOP",4)){


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-03T04:40:54Z

Nose/Nose.ino

+        if(CCP.str_match("KILL", 4)){
+            sleep_sensors = true;
+        }
+        break;    


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

test/Nose/mcp3421_2/mcp3421_2.ino

github-actions · 2024-01-03T04:40:56Z

test/Nose/mcp3421_2/mcp3421_2.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-03T04:40:56Z

test/Nose/mcp3421_2/mcp3421_2.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-03T04:40:56Z

test/Nose/mcp3421_2/mcp3421_2.ino

+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 
+  bytes[0] = (char)((*_result >> 24) & 0xFF); //ライブラリの関数内で8bit右シフトしたときに発生したものなので無視


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-03T04:40:56Z

test/Nose/mcp3421_2/mcp3421_2.ino

+  bytes[1] = (char)((*_result >> 16) & 0xFF); 
+  bytes[0] = (char)((*_result >> 24) & 0xFF); //ライブラリの関数内で8bit右シフトしたときに発生したものなので無視
+  double pga=1;
+  double lsb=2*2.048/pow(2,18);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

771-8bit · 2024-01-03T15:03:24Z

@nihinihikun このコードってコードフォーマッタかけてない？

nihinihikun · 2024-01-03T23:57:50Z

まだかけてない

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|40| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|66| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|68| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|69| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|70| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|71| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|73| Missing space after , [whitespace/comma] [3]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|74| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|78| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/BME_mcp3421/BME_mcp3421.ino|81| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|10| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|24| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|28| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|31| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|32| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|33| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|34| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|36| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|37| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|41| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_2/mcp3421_2.ino|46| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|15| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|29| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|32| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|33| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|34| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/nose1/nose1.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/nose1/nose1.ino|29| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|45| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|46| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|47| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|49| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|51| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|53| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|54| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|58| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|63| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|64| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|65| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|66| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|69| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|71| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|76| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|79| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

Nose/Nose.ino

github-actions · 2024-01-13T02:43:04Z

test/Nose/trash/BME_high_rate/BME_high_rate.ino

+}
+
+
+void loop() { 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:43:04Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+
+#define SEALEVELPRESSURE_HPA (1013.25)
+
+Adafruit_BME280 bme; 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:43:04Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+Adafruit_BME280 bme; 
+MCP342X myADC;
+
+unsigned long delayTime;


[cpplint] _{reported by reviewdog 🐶}
Use int16/int64/etc, rather than the C type long [runtime/int] [4]

github-actions · 2024-01-13T02:43:05Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+}
+
+
+void loop() { 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:43:05Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+    byte bytes[4];
+    myADC.startConversion();
+    myADC.getResult(&result);
+    ConvertToVoltage(&result,&voltage);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|36| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|37| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|38| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|39| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|41| Missing space after , [whitespace/comma] [3]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|42| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/mcp3421_pico/mcp3421_pico.ino|51| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
test/Nose/trash/nose1/nose1.ino|7| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|10| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
test/Nose/trash/nose1/nose1.ino|29| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|45| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|46| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|47| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|49| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|51| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|53| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|54| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|58| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|63| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|64| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|65| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
test/Nose/trash/nose1/nose1.ino|66| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|69| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|71| Missing space after , [whitespace/comma] [3]
test/Nose/trash/nose1/nose1.ino|76| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/trash/nose1/nose1.ino|79| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
test/Nose/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2024-01-13T02:50:19Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+    myADC.getResult(&result);
+    ConvertToVoltage(&result,&voltage);
+    Serial.print("voltage:");
+    Serial.println(voltage,10);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T02:50:19Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+    Serial.println();
+}
+
+void ConvertToVoltage(int32_t* _result,double* voltage){


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T02:50:19Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+
+void ConvertToVoltage(int32_t* _result,double* voltage){
+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T02:50:19Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+void ConvertToVoltage(int32_t* _result,double* voltage){
+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T02:50:19Z

test/Nose/trash/BME_mcp3421/BME_mcp3421.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:50:21Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  Wire.setSCL(PIN1_SCL);
+  Wire.begin();  // join I2C bus
+//   TWBR = 12;  // 400 kHz (maximum)
+  Serial.begin(9600); // Open serial connection to send info to the host    


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:50:21Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  byte bytes[4];
+  myADC.startConversion();
+  myADC.getResult(&result);
+  ConvertToVoltage(&result,&voltage);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T02:50:21Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  ConvertToVoltage(&result,&voltage);
+
+  Serial.print("voltage:");
+  Serial.println(voltage,10);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T02:50:21Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+
+  Serial.print("voltage:");
+  Serial.println(voltage,10);
+}  


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T02:50:21Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  Serial.print("voltage:");
+  Serial.println(voltage,10);
+}  
+void ConvertToVoltage(int32_t* _result,double* voltage){


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

nihinihikun · 2024-01-13T02:53:09Z

@771-8bit trashの中身で余分なスペースが出ちゃってるっていう警告と，C言語の書き方しててデバックしにくよっていう警告以外致命的な問題ないので，マージしてほしい．

ちなみにここまでは，ノーズのソフトウェア(ほぼFM仕様)をやってた．

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

test/Nose/xiaotest/xiaotest.ino|9| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

github-actions · 2024-01-13T09:29:22Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+}  
+void ConvertToVoltage(int32_t* _result,double* voltage){
+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:22Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+void ConvertToVoltage(int32_t* _result,double* voltage){
+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:22Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

github-actions · 2024-01-13T09:29:22Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  byte bytes[4];
+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:22Z

test/Nose/trash/mcp3421_pico/mcp3421_pico.ino

+  bytes[3] = (char)(*_result & 0xFF);
+  bytes[2] = (char)((*_result >> 8) & 0xFF);
+  bytes[1] = (char)((*_result >> 16) & 0xFF); 
+  bytes[0] = (char)((*_result >> 24) & 0xFF); //ライブラリの関数内で8bit右シフトしたときに発生したものなので無視


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:24Z

test/Nose/trash/nose1/nose1.ino

+void DevideBytes(int32_t* _result,char* bytes){
+    bytes[2] = (char)(*_result & 0xFF);
+    bytes[1] = (char)((*_result >> 8) & 0xFF);
+    bytes[0] = (char)((*_result >> 16) & 0xFF); 


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:24Z

test/Nose/trash/nose1/nose1.ino

+    bytes[0] = (char)((*_result >> 16) & 0xFF); 
+}
+
+void ConvertToVoltage(char* bytes,double* voltage){


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T09:29:24Z

test/Nose/trash/nose1/nose1.ino

+
+void ConvertToVoltage(char* bytes,double* voltage){
+    double pga=1;
+    double lsb=2*2.048/pow(2,18);


[cpplint] _{reported by reviewdog 🐶}
Missing space after , [whitespace/comma] [3]

github-actions · 2024-01-13T09:29:24Z

test/Nose/trash/nose1/nose1.ino

+    byte msb=(bytes[0]>>6)&0x01;
+    uint32_t outputcode=bytes[2]|(bytes[1]<<8)|((bytes[0]*0x01)<<16);
+    if(msb==0x00){//正の値
+    *voltage=(double)(outputcode)*lsb/pga;


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:29:24Z

test/Nose/trash/nose1/nose1.ino

+    *voltage=(double)(outputcode)*lsb/pga;
+    }else{//負の値
+    outputcode=((~outputcode)&0x01FFFF)+1;//2の補数
+    *voltage=-(double)(outputcode)*lsb/pga;


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use static_cast(...) instead [readability/casting] [4]

github-actions · 2024-01-13T09:36:00Z

test/Nose/xiaotest/xiaotest.ino

+  delay(1000);
+  digitalWrite(13, LOW);
+  delay(1000);
+}


[cpplint] _{reported by reviewdog 🐶}
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

into nose_software1

771-8bit · 2024-01-13T09:57:37Z

@771-8bit trashの中身で余分なスペースが出ちゃってるっていう警告と，C言語の書き方しててデバックしにくよっていう警告以外致命的な問題ないので，マージしてほしい．

ちなみにここまでは，ノーズのソフトウェア(ほぼFM仕様)をやってた．

余分なスペースが出ちゃってるっていう警告はフォーマッタかけてください．
C言語の書き方しててデバックしにくよっていう警告ではなくてキャスト方法の警告とか型がはっきりしないとか中身ある指摘なので修正してほしいです．
とりあえず/test/Nose/は無視するようにしました．

Nose/Nose.inoはちゃんとlinterの警告通り修正してほしいんだけど，今履歴がごちゃごちゃなのでNose/Nose.inoだけ別プルリクで出し直してほしい
あとNoseフォルダの中のドキュメントとdocs/Noseの中って区別ある？

into nose_software1

nihinihikun added 8 commits December 26, 2023 22:04

nose software develop start, try mcp3421

3185e41

adc covert to voltage, successed

23b9a6d

test rp2040 and mcp3421

d75e37a

add readme to leave note

37b76f5

Create bme280test.ino

3f9322f

mcp3421とBME280統合

6ffb118

Create nose1.ino

c1504fd

overruntest

2807d40

nihinihikun requested a review from 771-8bit December 29, 2023 14:46

nihinihikun self-assigned this Dec 29, 2023

github-actions bot reviewed Dec 29, 2023

View reviewed changes

Update arduino_ci.yml

baac4f9

github-actions bot reviewed Dec 30, 2023

View reviewed changes

771-8bit added 2 commits December 30, 2023 13:42

Update arduino_ci.yml

918a4f8

Update arduino_ci.yml

68883fb

github-actions bot reviewed Dec 30, 2023

View reviewed changes

Update arduino_ci.yml

1861f6e

github-actions bot reviewed Dec 30, 2023

View reviewed changes

ファイル整理

5e1f8e0

github-actions bot reviewed Dec 31, 2023

View reviewed changes

add status check

9f18972

github-actions bot reviewed Jan 3, 2024

View reviewed changes

delete missing spaces

cc9d769

github-actions bot reviewed Jan 13, 2024

View reviewed changes

delete extra variables

b7cf0ff

github-actions bot reviewed Jan 13, 2024

View reviewed changes

Update arduino_ci.yml

0df9e7f

github-actions bot reviewed Jan 13, 2024

View reviewed changes

Update arduino_ci.yml

e4688e0

github-actions bot reviewed Jan 13, 2024

View reviewed changes

771-8bit added 6 commits January 13, 2024 18:38

Update arduino_ci.yml

5c8b4d6

Merge branch 'main' into nose_software1

0fced30

Update arduino_ci.yml

a400766

Merge branch 'nose_software1' of https://github.com/core-rocket/24th-ise

30499e9

into nose_software1

Merge branch 'main' into nose_software1

2ef5251

Update arduino_ci.yml

1884bef

771-8bit and others added 3 commits January 13, 2024 18:57

delete Nose Build CI

5886f89

modify C-style castings

f13216a

Merge branch 'nose_software1' of https://github.com/core-rocket/24th-ise

ef97a3f

into nose_software1

nihinihikun merged commit 2884b34 into main Jan 13, 2024
4 checks passed

nihinihikun deleted the nose_software1 branch January 13, 2024 15:10

		}


		void loop() {

		}


		void loop() {

		}


		void loop() {

Nose software1 #12

Nose software1 #12

Conversation

nihinihikun commented Dec 29, 2023

概要

背景

変更範囲

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 29, 2023

Choose a reason for hiding this comment

github-actions bot Dec 29, 2023

Choose a reason for hiding this comment

github-actions bot Dec 29, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

771-8bit commented Dec 30, 2023

771-8bit commented Dec 30, 2023

771-8bit commented Dec 30, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot Dec 30, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot Dec 31, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment

github-actions bot Jan 3, 2024

Choose a reason for hiding this comment