Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional request-reply pair ICMP/ICMPv6: Extended Echo #23

Open
duffy-ocraven opened this issue Sep 23, 2020 · 0 comments
Open

additional request-reply pair ICMP/ICMPv6: Extended Echo #23

duffy-ocraven opened this issue Sep 23, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@duffy-ocraven
Copy link

At https://tools.ietf.org/html/rfc8335 an additional request-reply pair is documented.
ICMP field Type: Extended Echo Request. The value for ICMPv4 is 42. The value for ICMPv6 is 160
ICMP field Type: Extended Echo Reply. The value for ICMPv4 is 43. The value for ICMPv6 is 161

Since that wasn’t in the version 1 table of the reference Corelight python, hashes using that code would set one or the other "port-like value" to the code octet instead of to the type octet of the corresponding request-response peer. This issue was also reported as: corelight/pycommunityid#2 (comment)

This specific case also highlights that: which pairs are in the table of the corresponding request-response ICMP and ICMPv6 pairs, is a specification point, and should not be subject to variation, or derived from a reference implementation outside of the specification.

@ckreibich ckreibich added the enhancement New feature or request label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants