Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using weirdtls.BrokerDefaultTLSDialer when TLS is disabled causes client.NewClient() to hang #2

Open
simeonmiteff opened this issue Jan 11, 2024 · 0 comments
Open

Using weirdtls.BrokerDefaultTLSDialer when TLS is disabled causes client.NewClient() to hang #2

simeonmiteff opened this issue Jan 11, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@simeonmiteff
Copy link
Collaborator

When zeek is running with Broker::disable_ssl = T and we (incorrectly) use client.NewClient() with the weirdtls.BrokerDefaultTLSDialer, the underlying openssl connection function hangs indefinitely and NewClient() never returns.

One fix might be to use the go-openssl DialTimeout function instead, but this requires an API change in the library:

https://github.com/libp2p/go-openssl/blob/v0.1.0/net.go#L90
@simeonmiteff simeonmiteff added the good first issue Good for newcomers label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simeonmiteff