Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearOperatorTestCase's _test_triangular_linear_op_inv_quad_logdet is skipped and fails otherwise #11

Open
SebastianAment opened this issue Sep 8, 2022 · 0 comments

Comments

@SebastianAment
Copy link
Collaborator

LinearOperatorTestCase's _test_triangular_linear_op_inv_quad_logdet is not executed in the current test suite because of the leading underscore. When this underscore is removed, the test executes but fails.

In particular, the test calls _test_inv_quad_logdet and checks if this uses a call to cholesky. However, derived test classes like TestLowRankRootAddedDiagLinearOperator, TestLowRankRootAddedDiagLinearOperatorBatch and TestSumKroneckerLinearOperator apparently don't use Cholesky-based inference for this step (see here for the low rank test), which makes the test fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant