Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with WebPack 5 #126

Closed
Celian-abd opened this issue Jun 10, 2022 · 3 comments
Closed

Build error with WebPack 5 #126

Celian-abd opened this issue Jun 10, 2022 · 3 comments

Comments

@Celian-abd
Copy link
Contributor

Hi there,

we just wanted to warn that Cornerstone3D has a build issue with Webpack 5 due to the detect-gpu library

The issue is raised here : pmndrs/detect-gpu#89

For those working with react 18 with create-react-app will have this issue.

I put this here because once detect-gpu will be fixed it will need to upgrade cornerstone 3d dependencies

Salim & Celian

@eric-taix
Copy link

We are facing this issue and we're unable to build a internal prod version due to this issue.
Do you have any workaround in the meantime?

On our side we gonna fork detect-gpu library and try to remove terser webpack plugin which seems to fix this issue as mentioned in pmndrs/detect-gpu#89 (comment) and we'll let you know

@gabriellebaudy
Copy link
Contributor

Hello,

We found and submitted a fix, available here.

I hope it can be merged soon!

@sedghi
Copy link
Member

sedghi commented Jul 29, 2022

Is your problem resolved now? @Celian-abd

@sedghi sedghi closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants