Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] createVOISynchronizer signature is incorrect #1431

Open
jeremygau opened this issue Aug 20, 2024 · 0 comments
Open

[Bug] createVOISynchronizer signature is incorrect #1431

jeremygau opened this issue Aug 20, 2024 · 0 comments

Comments

@jeremygau
Copy link

jeremygau commented Aug 20, 2024

Describe the Bug

Hello,
The signature of the createVOISynchronizer function is incorrect. The options should be optional because they are assingned in the body of the function but currently they are required so Typescript throw an error when we don't provide them.

Steps to Reproduce

Use the createVOISynchronizer function with typescript

The current behavior

createVOISynchronizer(
  synchronizerName: string,
  options: VOISynchronizerOptions
)

The expected behavior

createVOISynchronizer(
  synchronizerName: string,
  options?: VOISynchronizerOptions
)

OS

macOs

Node version

21.7.3

Browser

All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant