Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Annotations appear on incorrect images when using the wadoURI fileManager #1455

Closed
plt-joey opened this issue Sep 4, 2024 · 1 comment

Comments

@plt-joey
Copy link
Contributor

plt-joey commented Sep 4, 2024

Describe the Bug

When loading images with cornerstoneDICOMImageLoader.wadouri.fileManager.add they are given an id with the format dicom:<image number>. Annotations created on images loaded this way will also show up on the images whose image number matches the last digits of the image number they were created on.

For example: If you were to load 200 images, then create an annotation on the image with the ID dicom:126 it will also be displayed when rendering the images dicom:26 or dicom:6.

Steps to Reproduce

I have created a minimal repro of this issue here (instructions in the README): https://github.com/plt-joey/cornerstone-issue-repro/tree/master

The current behavior

The repro displays two viewports with the CircleROITool active, the left viewport is displaying dicom:0, the right viewport is displaying dicom:10. If you create an annotation in the right viewport it will also be displayed in the left one, but notably the reverse is not true, creating annotations in the left viewport only display in the left viewport.

This is not limited to displaying multiple viewports, the annotation will also incorrectly show up if you have a single viewport on dicom:10, create an annotation, then switch it to dicom:0

The expected behavior

The expected behavior is that annotations should only show up on the image they was created on.

OS

Windows 10

Node version

18.12.1

Browser

Chrome (128.0.6613.114) & Firefox (130.0)

@plt-joey
Copy link
Contributor Author

Created #1460 to address this

@sedghi sedghi closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants