Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xmpp specific code from jane_command_worker #12

Open
cosgroveb opened this issue Feb 9, 2012 · 2 comments
Open

Remove xmpp specific code from jane_command_worker #12

cosgroveb opened this issue Feb 9, 2012 · 2 comments
Assignees
Labels

Comments

@cosgroveb
Copy link
Owner

Offending code.

In xmpp multi-user-chat messages, the "from" field is a JID in the format: [email protected]/user_alias (XEP-0045 see reflected message stanza in Ex. 61).

We are pulling the "user_alias" off that string in our message records in jane_command_worker:handle_message. This should be handled in jane_xmpp_server.

@benmills
Copy link
Collaborator

benmills commented Feb 9, 2012

Good catch. I think we should lump this into issue #7, creating configuration modules.

@cosgroveb
Copy link
Owner Author

Probably.

I noticed this awhile back while working on my IRC spike but haven't gotten around to fixing it, just yet. :)

@ghost ghost assigned cosgroveb Feb 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants