Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review best way to construct delta field #8

Open
adematti opened this issue Dec 9, 2021 · 0 comments
Open

Review best way to construct delta field #8

adematti opened this issue Dec 9, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adematti
Copy link
Member

adematti commented Dec 9, 2021

There are currently different implementations for constructing delta field ~ data / randoms - 1 (smoothing of the data and randoms fields before computing delta, or after computing delta, threshold in number of randoms per cell), which follow the prescriptions used in original Bautista and White codes, e.g.:

def set_density_contrast(self, ran_min=0.01, smoothing_radius=15.):
vs.
def set_density_contrast(self, ran_min=0.75, smoothing_radius=15., **kwargs):

It'd be good to converge on a common prescription. Gaussian mocks (e.g. https://github.com/cosmodesi/pyrecon/blob/main/nb/e2e_examples.ipynb) with selection function in them may assist the choice.
WIthin current implementation, if randoms density is too small there will be a lot of delta points set to 0, hence highly inefficient reconstruction.

@adematti adematti added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant