Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mock modules from simapp binary app.go #7066

Closed
3 tasks
colin-axner opened this issue Aug 7, 2024 · 0 comments · Fixed by #7444
Closed
3 tasks

Remove mock modules from simapp binary app.go #7066

colin-axner opened this issue Aug 7, 2024 · 0 comments · Fixed by #7444
Assignees
@colin-axner
Labels
e2e testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

Mock module should not be used in e2e's and should be removed from the top level simapp app.go

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests e2e labels Aug 7, 2024
@colin-axner colin-axner mentioned this issue Oct 14, 2024
Merged
10 tasks
@colin-axner colin-axner self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
e2e testing Testing package and unit/integration tests
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove mock from top level simapp app.go cosmos/ibc-go
1 participant
@colin-axner