Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break API of NewPacket constructor to add protocol and app versions #7140

Open
crodriguezvega opened this issue Aug 13, 2024 · 0 comments
Open

Break API of NewPacket constructor to add protocol and app versions #7140

crodriguezvega opened this issue Aug 13, 2024 · 0 comments
Labels
feat: ibc-eureka icebox Issues that we will not address for the time being
Milestone
v11.0.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Aug 13, 2024 •
edited
Loading

We added the NewPacketWithVersion constructor that differs from the existing NewPacket constructor in that sets the protocol version to V2 and it has an extra argument for app version.

Proposal

Break the API of NewPacket instead and accept two new arguments for protocol and app versions. Remove NewPacketWithVersion (can we added back if needed if we back port the feature).

This issue will be handled internally by IBC team.
@crodriguezvega crodriguezvega added icebox Issues that we will not address for the time being feat: ibc-eureka labels Aug 13, 2024
@crodriguezvega crodriguezvega added this to the Eureka beta milestone Aug 13, 2024
@chatton chatton modified the milestones: Eureka beta, v11.0.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: ibc-eureka icebox Issues that we will not address for the time being
Projects
IBC Eureka
Status: On hold ❌
Milestone
v11.0.0
Development

No branches or pull requests
2 participants
@crodriguezvega @chatton