Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: better distinguish between ConsumerValidatorBytePrefix and ConsumerValidatorsBytePrefix #2087

Open
insumity opened this issue Jul 23, 2024 · 4 comments
Open

nit: better distinguish between ConsumerValidatorBytePrefix and ConsumerValidatorsBytePrefix #2087

insumity opened this issue Jul 23, 2024 · 4 comments
Assignees
@aditipatelpro
Labels
good first issue Good for newcomers type: tech-debt Slows down development in the long run

Comments

@insumity
Copy link
Contributor

Problem

Byte prefixes ConsumerValidatorsBytePrefix and ConsumerValidatorBytePrefix almost have the same name although they're used when storing vastly different things.

This issue is just a reminder to clean up their naming so it's not as confusing.
@insumity insumity added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Jul 23, 2024
@insumity insumity mentioned this issue Jul 23, 2024
Merged
12 tasks
@insumity insumity added good first issue Good for newcomers and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jul 25, 2024
@aditipatelpro
Copy link

@insumity, I would love to work on this issue.
Please let me know if you are accepting open-source contributions.

@mpoke mpoke added the type: tech-debt Slows down development in the long run label Sep 17, 2024
@mpoke
Copy link
Contributor

mpoke commented Sep 17, 2024

@aditipatelpro Sorry for the late reply. We were focusing on the ICS 6.0.0 release and we missed your comment. We are gladly accepting external contributions. Please let us know if you still want to take this over so that I can assign it to you. Thanks.

@aditipatelpro
Copy link

@mpoke, I am still excited and available to work on this issue. thank you.

@mpoke
Copy link
Contributor

mpoke commented Oct 3, 2024

@aditipatelpro Thanks. I assigned the issue to you. Please let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditipatelpro aditipatelpro

Labels
good first issue Good for newcomers type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: 🏗 F3: InProgress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@insumity @aditipatelpro @mpoke