-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Almost) all tx errors, except for "packet messages are redundant", are considered as "Tx Failure" in Prometheus metrics #1500
Comments
@freak12techno The account sequence error is automatically fixed during runtime to submit another Tx after re-parsing the new err msg expected value. Thus no events should be thrown for this anymore as there is nothing the event consumer would need to do code: relayer/relayer/chains/cosmos/tx.go Lines 709 to 723 in d740575
|
@Reecepbcups yeah, but I checked the logs during the period that's on my screenshot, and it has only this error in logs that I provided, that's why I think it's misclassified |
Actually I found one new of these errors, and it kinda matches the
Do you think it might be the one that actually is represented by this metric value? |
this seems correct. as @Reecepbcups pointed out, the relayer should be catching the account sequence errors and attempting to send a broadcast a new tx with the correct sequence number so i don't think those should end up being reported in metrics |
Gotcha, so I don't have any more questions here and will close it. Thanks you both for elaborating, that was really helpful! |
So I had this error:
And it should've been displayed in metrics as a metric with a separate
cause
, as it's listed here:relayer/relayer/processor/message_processor.go
Line 43 in d740575
Also, almost all of tx_errors seem to be either "packet messages are redundant", or "Tx Failure", except for one, since the server startup:
Seems like something is wrong here.
JFYI, I am on the latest commit.
The text was updated successfully, but these errors were encountered: