Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display file path in title bar #1417

Open
LostInCompilation opened this issue Jan 14, 2023 · 5 comments
Open

Option to display file path in title bar #1417

LostInCompilation opened this issue Jan 14, 2023 · 5 comments
Assignees
Labels
request feature requests from users

Comments

@LostInCompilation
Copy link

Is your feature request related to a problem? Please describe.
Option to enable displaying the currently opened file path in the title bar.
I know about #1346 but it is not clear to me, why such a feature is not implemented. A lot of other text editors provide this feature, and it is in fact essential when comparing files with the same name.

I think I will make a PR to implement this. Just let me know if it would be accepted.

Describe the solution you'd like
Display the path in the title bar.

Describe alternatives you've considered
I know about the path in the info sidebar. But I don't want to have a side bar open which uses a lot of space just for that small info.

@LostInCompilation LostInCompilation added the request feature requests from users label Jan 14, 2023
@1024jp 1024jp self-assigned this Jan 28, 2023
@1024jp 1024jp modified the milestone: 4.4.5 Jan 28, 2023
@1024jp
Copy link
Member

1024jp commented Jan 30, 2023

An issue is that the window title space with the toolbar is not wide enough to put the long file path. Likewise, the title space for tabbed windows.
In addition, I want to avoid adding a new option to the settings as much as possible to keep the settings simple enough.
On the other side, I understand your issue.
Let me think...

Screenshot 2023-01-30 at 22 36 04

@LostInCompilation
Copy link
Author

LostInCompilation commented Jan 30, 2023

How about something like Finder is doing: Expand on hover.

Screen.Recording.2023-01-30.at.17.46.26.mov

@1024jp
Copy link
Member

1024jp commented Jan 30, 2023

How about something like Finder is doing: Expand on hover.

That is exactly the standard behavior on the unified type toolbar presentation when the title is long.
The issue there is the tail of the title text is truncated and it makes distinguishing between documents more difficult.
It would be good if there were APIs to control the title string on expanded and truncated but not.

@1024jp
Copy link
Member

1024jp commented Jan 30, 2023

I currently think the way to display the document title in the Open Recent menu (without icons) is smart.
It shows the parent folder only when there are multiple documents with the same name.
I don't know if there is an easy way to implement it. Let me research.

Screenshot 2023-01-31 at 8 55 29

@LostInCompilation
Copy link
Author

A simpler solution would be to just hardcode clipping the path on the left side.
So we always end up with something like this in the title bar:
...\path\to\file.txt

That should be easy to implement by just getting the available size in the title bar.

Let me know when you found something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request feature requests from users
Development

No branches or pull requests

2 participants